Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(host): getScriptSnapshot must also call fileNames.add #364

Merged
merged 1 commit into from
Jun 24, 2022
Merged

fix(host): getScriptSnapshot must also call fileNames.add #364

merged 1 commit into from
Jun 24, 2022

Commits on Jun 22, 2022

  1. fix(host): getScriptSnapshot must also call fileNames.add 

    - the `fileNames` Set that was previously introduced in c86e07b caused a regression during watch mode
  - this is because `setSnapshot` was updated to call `this.fileNames.add`, but `getScriptSnapshot` was not
    - instead of updating both to be the same, we can just call `setSnapshot` from `getScriptSnapshot` as this code is supposed to be identical
      - also rename `data` -> `source` for consistency and clarity (`source` is a more specific name)
    @agilgur5
    agilgur5 committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    5453ad7 View commit details
    Browse the repository at this point in the history