node v17: Error loading tslib helper library

[aladdin-add]

What happens and why it is wrong

Error loading `tslib` helper library.
/Users/weiran/repo/dian/tsdx/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:25177
    throw e;
    ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './package.json' is not defined by "exports" in /Users/weiran/repo/dian/tsdx/node_modules/rollup-plugin-typescript2/node_modules/tslib/package.json

Environment

Versions

  Node: 17.0.0
  OS: macOS 12.0
  yarn: 3.0.2

   rollup: ^2.57.0 => 2.58.0 
    rollup-plugin-typescript2: ^0.30.0 => 0.30.0 
    typescript: ^4.4.3 => 4.4.4

rollup.config.js

`rollup.config.js`:

tsconfig.json

`tsconfig.json`:

package.json

`package.json`:

plugin output with verbosity 3

plugin output with verbosity 3:

[aladdin-add]

this is from weiran-zsd/dts-cli#78.

[yoeunes]

Hello @aladdin-add did you find any solution for this error ? I got it also with node 17

  Node: v17.0.1
  npm: 8.1.0
  OS: Ubuntu
  rollup: 2.58.0
 rollup-plugin-typescript2: 0.30.0

[aladdin-add]

1. just down to node < 17
2. yarn resolutions:

"resolutions":{
  "tslib": "2.3.1"
}

[bluelovers]

Checking in on this, any updates?

i think my pr can fix this

[bluelovers]

can try this before merge apply

"rollup-plugin-typescript2": "bluelovers/rollup-plugin-typescript2#pr/node-v17-tslib-002",

[ezolenko]

@bluelovers I'm having trouble building with node 17 (unrelated to your PR), because something breaks semver either at runtime (before upgrading commonjs plugin) or at build time, so I had to disable version check. Do you see those problems at all?

See this commit, which is basically your PR but with any changes needed to upgrade: cb2621f

I used normal resolve (stole it from rollup-plugin-typescript):

import resolve from "resolve";
const tslibPath = resolve.sync("tslib/tslib.es6.js");

Is your approach with @yarn-tool/resolve-package significantly better?

[bluelovers]

u need build at node.js 16, and disable version test before publish new version once

after this, enable ur version test will work

[aladdin-add]

a workaround: if you are using docker, you can change the node:latest => node:lts(or node:16/14) to avoid the error.

[bluelovers]

Is your approach with "@yarn-tool/resolve-package" significantly better?

@ezolenko u can see source code for watch what i do make it work on node.js 17

https://github.com/bluelovers/ws-yarn-workspaces/blob/e57f6acafbe7c00c43593823a5d16ada08aeb920/packages/%40yarn-tool/resolve-package/index.ts#L13

[ezolenko]

@bluelovers released in 0.31.0, thanks for the PR

[aladdin-add]

confirmed it has been fixed in v0.31.0. 🎉

and seems also fixed #267?

[agilgur5]

This seems to have been fixed upstream in tslib 2.4.0's package.json since microsoft/tslib#135 was recently merged and released. Basically the root cause is that the old way of doing * package exports was deprecated in Node 16 (c.f. #267), then removed in Node 17... but the new way didn't work on older Node versions so there were some compatibility issues to work through (now tslib uses both the old and new ways).

Is your approach with @yarn-tool/resolve-package significantly better?

So if we upgrade tslib to ^2.4.0 we should be able to move back to the old method using require.resolve and drop the additional dep of @yarn-tool/resolve-package.

Also, to workaround prior to 2.4.0 without an additional dep, we could have also resolved to absolute paths, as package exports do not prevent importing internals via absolute paths (exports are a "weak" encapsulation).

EDIT: see my tslib upgrade PR in #326