Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AllowDynamicProperty for PHP8.2 #10

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Fix AllowDynamicProperty for PHP8.2 #10

merged 1 commit into from
Dec 7, 2022

Conversation

adoy
Copy link

@adoy adoy commented Nov 11, 2022

Since the project uses namespaces, #[AllowDynamicProperties] need to be specified with a forward \.

@shyim
Copy link

shyim commented Nov 22, 2022

same as https://github.com/ezimuel/ringphp/pull/9/files

@adoy
Copy link
Author

adoy commented Nov 23, 2022

Yes. Didn't saw that an other PR was created. Also this one also add an other missing #[AllowDynamicProperties] on FutureArray.

@ezimuel ezimuel merged commit 7887fc8 into ezimuel:master Dec 7, 2022
@ezimuel
Copy link
Owner

ezimuel commented Dec 7, 2022

Thanks @adoy for your contribution

@ezimuel
Copy link
Owner

ezimuel commented Dec 7, 2022

Just released ver. 1.2.2

@adoy
Copy link
Author

adoy commented Dec 7, 2022

Thanks to you.

@adoy adoy deleted the php-8.2 branch December 7, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adoy @shyim @ezimuel