Add badge label for buttons #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,6 +77,12 @@ - (void)viewDidLoad { | |||
| [weakSelf showAlertViewWithTitle:@"Globe" | |||
| message:@"You have chosen the globe view controller."]; | |||
| } atIndex:4]; | |||
|
|
|||
| // tabBarController.badgeFont = [UIFont systemFontOfSize:10 weight:2]; | |||
There was a problem hiding this comment.
Please let's don't leave commented lines of code here :)
We could instead leave a comment that says:
// For more customisation of badge labels, see properties in ESTabBarController.h.
|
@GigabyteTheOne This PR is good, I really apologise for the delay! If you can have a look at the comments I wrote and fix those things, that would be awesome. I'll merge it afterwards. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an ability to set up badge text for every button and customize this label.
I've also added an ability to get current view controllers stack