-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: return job ID from client push
What did we change? Have `SidekiqPublisher::Worker.client_push` return a job ID string, which matches the sidekiq gem behavior. Currently `.client_push` returns the inserted `SidekiqPublisher::Job` ActiveRecord instance. Why are we doing this? Having a consistent return value between the native sidekiq gem and the sidekiq_publisher gem makes things easier to handle. Otherwise clients have to juggle using `#job_id` method (for sidekiq_publisher gem) or the job ID string (for sidekiq gem). For example: ```rb job = ExampleJob.perform_async logger.info msg: "some example", job_id: job.try(:job_id) || job ```
- Loading branch information
1 parent
9540254
commit 3e28611
Showing
2 changed files
with
31 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters