fix(output): quote symbolic links correctly when their destinations contain spaces #716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with the way symlinks are quoted when their destination has spaces in the name.
Below is a set of test cases that demonstrates the problem:
In
symlink-to-dest-with-spaces
, the link has no spaces, but the destination does.eza
quoted the entire link display, instead of just the destination.In
symlink with spaces to dest with spaces
, the link and destination have spaces.eza
quoted the link and then also the entire link display, instead of quoting each separately.The issue is caused by the fact that the
escape
function always inserts the starting quote at the very beginning of the finished string, instead of only inserting it before the new part.It seems to have been introduced in #318.