Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leave nix install instructions open-ended #426

Closed
wants to merge 3 commits into from

Conversation

CobaltCause
Copy link

See here. Plus nix profile and imperative package management in general is usually the wrong thing to do when using Nix.

Nix users should be able to reference existing documentation for how to install things; this repository should simply say where it's packaged and leave it up to the user to decide how they want to install it.

@CobaltCause CobaltCause force-pushed the nix-installation branch 2 times, most recently from f662948 to 8e4dec3 Compare September 26, 2023 16:41
@cafkafk
Copy link
Member

cafkafk commented Sep 26, 2023

Plus nix profile and imperative package management in general is usually the wrong thing to do when using Nix.

True, but most new Nix users will prefer doing it this way, despite what is right. Perhaps we can mention that they should do it another way, but outright removing it is just removing an on ramp IMO.

@CobaltCause
Copy link
Author

I would've thought that new users are the exact type of people you'd want to direct away from imperative approaches because of the footguns involved...

@cafkafk
Copy link
Member

cafkafk commented Sep 26, 2023

I would've thought that new users are the exact type of people you'd want to direct away from imperative approaches because of the footguns involved...

Well, if they don't know how to add it to their config they're gonna need it I assume? We can add https://stop-using-nix-env.privatevoid.net/ as well as a disclaimer.

Note
The preferred method of installing packages on nix...

@CobaltCause
Copy link
Author

CobaltCause commented Sep 26, 2023

Well, if they don't know how to add it to their config they're gonna need it I assume?

I don't think it should be the job of every software project to include instructions on how to do this; users should be able to reference existing upstream documentation to gain this knowledge.

The preferred method of installing packages on nix...

... would probably best be conveyed as a (surprisingly large) flowchart.

@CobaltCause
Copy link
Author

There's an upstream issue on this topic: NixOS/nix.dev#554

@cafkafk
Copy link
Member

cafkafk commented Sep 26, 2023

I don't think it should be the job of every software project to include instructions on how to do this;

Agree on the should, but in practice, people seem to ask for and like having it.

@CobaltCause
Copy link
Author

I understand and respect the desire to make users happy but I think this particular choice causes more harm than good. Having these options spoonfed to them might make them happy right now, but the inevitable >20 minute long conversation in Matrix initiated by said user about "why is this package misbehaving" down the line will be unpleasant for everyone involved.

@CobaltCause
Copy link
Author

See also helix-editor/helix#7064

See [here][0]. Plus `nix profile` and imperative package management in
general is usually the wrong thing to do when using Nix.

Nix users should be able to reference existing documentation for how to
install things; this repository should simply say where it's packaged
and leave it up to the user to decide how they want to install it.

[0]: https://stop-using-nix-env.privatevoid.net/
@CobaltCause CobaltCause changed the title don't give nix users bad advice leave nix install instructions open-ended Sep 26, 2023
@CobaltCause
Copy link
Author

CobaltCause commented Sep 26, 2023

(Apologies for the previous abrasive title/commit message)

@CobaltCause
Copy link
Author

If you're going to revert the point of my PR (1971193), I'd prefer if you'd just close it.

@CobaltCause CobaltCause deleted the nix-installation branch September 27, 2023 03:28
cafkafk pushed a commit that referenced this pull request Sep 27, 2023
cafkafk added a commit that referenced this pull request Sep 27, 2023
MartinFillon pushed a commit to MartinFillon/eza that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants