feat(icons): Add backlog of icons from various exa pull requests and others #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You clearly put a TON of work into this. Big thanks for sure 👍 If only github would render those icons in the gist |
lol
|
Addressed exa issues ogham/exa#1242, ogham/exa#1134, ogham/exa#1106, ogham/exa#1096 |
cafkafk
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Local testing and integration tests indicates this is working. Code looks sensible to me. Thanks for being so systematic in this PR, it makes it a lot easier to reveiw ❤️
If you wanna make more icon changes feel free to do so in follow up PRs (I see you pushed to this repo four hours ago). I'm merging now so other icon changes (which are sort of popular) build on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://gist.github.com/cfxegbert/9c502dce80eec8cf8298970902607fd7 for changes
Also changes the order the icons are checked. The old order was filename, if directory, extension. The new order is if directory, filename, extension.
Addresses issue #180 and pull requests #38, ogham/exa#1221, ogham/exa#1194, ogham/exa#1191, ogham/exa#1162, ogham/exa#1150, ogham/exa#1148, ogham/exa#1144, ogham/exa#1140, ogham/exa#1120, ogham/exa#1199, ogham/exa#1234