bug: Test and fix all bash completions

[daviessm]

Bash completions have been a bit unloved, we should go through and test/fix them.

[daviessm]

Save time by removing all completions and use this instead: https://docs.rs/clap_complete/4.4.1/clap_complete/
Depends on #197

[FilipeBento]

I'll add that version 0.18.20 added the --show-symlinks flag (yay!) but did NOT add it to the bash completions file. Version 0.18.21 might have the same issue with the zsh completions.

@daviessm @cafkafk

[FilipeBento]

The issue persists in release 0.20.1. The new options --follow-symlinks and --group-directories-last were added to --help and auto-complete, but at least --show-symlinks and --no-symlinks are missing.

Solution: After looking at the bash completion file eza, I believe it is simply a matter of adding all the missing options to eza --help. If we do so, they seem to be automatically loaded.

I lack the expertise to make such changes, but perhaps an external contributor can update the eza --help?

@daviessm @cafkafk

[cafkafk]

I believe it is simply a matter of adding all the missing options to eza --help. If we do so, they seem to be automatically loaded.

What makes you believe that is the case? Could you link to a mechanism in native bash that creates completions from help output?

Also, for what it's worth, creating a contribution that adds flags to the help flag is an easy first contribution for anyone interested.

[FilipeBento]

@cafkafk My programming skill is very rusty, but the autocomplete file seems to gather the flags from --help, as shown here:

eza/completions/bash/eza

Lines 57 to 64 in 74fed8c

	case "$cur" in
	# _parse_help doesn’t pick up short options when they are on the same line than long options
	--*)
	# colo[u]r isn’t parsed correctly so we filter these options out and add them by hand
	parse_help=$(eza --help | grep -oE ' (--[[:alnum:]@-]+)' | tr -d ' ' | grep -v '\--colo')
	completions=$(echo '--color --colour --color-scale --colour-scale --color-scale-mode --colour-scale-mode' "$parse_help")
	mapfile -t COMPREPLY < <(compgen -W "$completions" -- "$cur")
	;;

Specifically this

parse_help=$(eza --help | grep -oE ' (--[[:alnum:]@-]+)' | tr -d ' ' | grep -v '\--colo') 

(Also, thank you for all your work in maintaining this repo. It is amazing software. ❤️)