feat(color_eyre): add support to specify verbosity in HookBuilder #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the Verbosity public and added documentation Added verbosity method to HookBuilder
TheTollingBell
changed the title
TheTollingBell
changed the title
|
Looks good, I'm happy to merge this with the addition of some tests. Particularly what happens when conflicting verbosity is set via both the hook builder and the env. |
|
Sorry for being incommunicado for the past few days, I'll go ahead and fix Clippy failing. As it's configured right now, verbosity that is specified in HookBuilder overrides environment, though it is possible to write another function that would instead have environment override specified verbosity. |
|
Never mind about Clippy, all the warnings are not from changes in this pull request. |
|
clippy warnings should be fixed now |
|
@yaahc Is this ready to be merged, or is there something else I should do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where setting the environment is unsafe it would be more convenient to manually specify the verbosity without using the environment at all.