Support converting between anyhow::Error and eyre::Report automatically with ?
#178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
reviewed
Jun 21, 2024
| @@ -29,6 +29,7 @@ pyo3 = { version = "0.13", default-features = false, features = ["auto-initializ | |||
| indenter = "0.3.0" | |||
| once_cell = "1.4.0" | |||
| pyo3 = { version = "0.13", optional = true, default-features = false } | |||
| anyhow = "1.0" | |||
There was a problem hiding this comment.
Let's put this behind a feature?
ten3roberts
force-pushed
the
anyhow-compat
branch
3 times, most recently
from
07be581 to
a663f0a
Compare
ten3roberts
force-pushed
the
anyhow-compat
branch
from
a663f0a to
de939a5
Compare
ten3roberts
force-pushed
the
anyhow-compat
branch
2 times, most recently
from
5d5e18c to
037f999
Compare
ten3roberts
force-pushed
the
anyhow-compat
branch
from
137217a to
0668083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.