Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document automated release process #154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ten3roberts
Copy link
Contributor

No description provided.

@ten3roberts ten3roberts requested review from thenorili and yaahc and removed request for thenorili February 2, 2024 21:27
@ten3roberts ten3roberts added C-documentation Category: Improvements or additions to documentation P-important (Priority) something that contributes towards achieving the long term goals of the project A-eyre Area: eyre subcrate labels Feb 2, 2024
role only requires good faith and a basic understanding of our development
process.

[Discord]: https://discord.gg/z94RqmUTKB
[^1]: Okay, I'll admit it, it's really just the Rust Project's CoC :sweat_smile:

# Release Process
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always refine this, but we need something out now and ensure that releases go smoothly and don't drop commits

Copy link
Contributor

@thenorili thenorili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the return to cargo-release fully automatic like the commit description claims? IIRC a fair bit of what we were doing manually was handled by cargo-release previously -- have we checked that against the manual procedure to make sure it hasn't rotted?

The `master` branch contains all the latest changes and is considered unstable.

For each bugfix and non-breaking change, the relevant commits are cherry-picked to relevant stable release branches,
denoted by `releas-<major>.<minor>`. A new version is then published from each of the relevant stable release branches.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/releas/release

Comment on lines +191 to +192
highly encouraged, but not strictly required. The changelog *should not* be maintained on the stable release branches or
in the release commits, as this leads to them not being visible on the `master` branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain in more detail what you mean by "The changelog should not be maintained on the stable release branches or in the release commits, as this leads to them not being visible on the master branch."?

It's more important for users to have a changelog for releases than to have a changelog for master.

An automated changelog for releases would be fine if we can get that working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-eyre Area: eyre subcrate C-documentation Category: Improvements or additions to documentation P-important (Priority) something that contributes towards achieving the long term goals of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants