Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strings on last few examples #11

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Fix strings on last few examples #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ anyhow the following is valid.

```rust
// Works
let val = get_optional_val.ok_or_else(|| anyhow!("failed to get value)).unwrap();
let val = get_optional_val.ok_or_else(|| anyhow!("failed to get value")).unwrap();
```

Where as with `eyre!` this will fail due to being unable to infer the type for
Expand All @@ -307,10 +307,10 @@ via your return type or a type annotation.

```rust
// Broken
let val = get_optional_val.ok_or_else(|| eyre!("failed to get value)).unwrap();
let val = get_optional_val.ok_or_else(|| eyre!("failed to get value")).unwrap();

// Works
let val: Report = get_optional_val.ok_or_else(|| eyre!("failed to get value)).unwrap();
let val: Report = get_optional_val.ok_or_else(|| eyre!("failed to get value")).unwrap();
```
[Report]: https://docs.rs/eyre/*/eyre/struct.Report.html
[`eyre::EyreContext`]: https://docs.rs/eyre/*/eyre/trait.EyreContext.html
Expand Down