New release? #215
Comments
|
A big +1 from me: the currently released color-eyre crate transitively depends on atty, which is unmaintained. This is messing up my |
The goal here is to remove a transitive dependency on the deprecated `atty` crate, which trips `cargo deny` because it's unmaintained. This currently does not eliminate the dependency completely, as we're still waiting on `color-eyre` to release [1], and merging this PR as-is would result in `cargo deny` being even more angry at using different versions of the same crate, so this PR is a draft for now. The update is non-trivial because `owo-colors` no longer supports checking whether stdin supports colors, which is, well, reasonable. Semantically, this cements the `Stream` trait as something that can be printed onto, rather than a generic-purpose stream. Uses of `as_tty` are replaced with a direct call to the `std` `is_terminal` function, and `Stream` (now called `OwoStream`) now exclusively handles mapping `std` I/O streams to `owo-colors` streams. [1]: eyre-rs/eyre#215
|
@workingjubilee had recently pinged me to get out a new release. specifically wanting to land #207 getting out into the wild (so 254309f reaches a release) I think I should be able to cut a new 0.6.x release at the very least. I'm sorry for the delays, I've had very low energy for maintenance here and have been focusing most of my energy into growing the team but I think many of the other members have found themselves in similar situations so here we are. |
|
I could use some help w/ this if possible, if there are any changes you need for the next release can you please help me verify if they're available in the https://github.com/eyre-rs/eyre/tree/release-0.6 or https://github.com/eyre-rs/eyre/tree/color-eyre-0.6 or open the appropriate backport PRs and ping me on them if they're not? I believe those are the respective release branches for the current versions of eyre and color-eyre that @ten3roberts set-up for us (correct me if I'm wrong). master reflects the planned 1.0 release but I don't think it's ready to go out rn since we have a few in flight PRs we want to include for that. |
|
No need to apologize. We all hit points of low energy, that's how open source goes. It looks like the commit I would need is missing from both branches. Should I open PRs against both or is one of them preferred? |
|
both branches would be best, thank you ^_^ |
|
This doesn't look like it will be a small amount of work. I haven't dug into actually understanding the internals of the crate or the history, so this might be missing something important, but it looks like the crux of this will be a backport of #160. I haven't seen anything in there that jumps out as a breaking change yet, but I suspect I'm quickly headed that way. I think I will close this issue out and wait until the 1.0 to get the commits I need. |
First off, thank you for the fantastic crate.
We are currently pinned to the commit 7706273 to pick up that fix. I'd love to get us on a released version. Is a new patch release planned soon?
The text was updated successfully, but these errors were encountered: