Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imageContextStack is not safe #548

Closed
wangwentong-lunaon opened this issue Mar 19, 2019 · 2 comments
Closed

imageContextStack is not safe #548

wangwentong-lunaon opened this issue Mar 19, 2019 · 2 comments
Assignees
@mnndnl
Labels
bug
Milestone
0.9.7

Comments

@wangwentong-lunaon
Copy link

if i use "DispatchQueue.global().async" to parse more svg, imageContextStack might crash
@ystrot ystrot self-assigned this Mar 19, 2019
@ystrot
Copy link
Member

ystrot commented Mar 19, 2019

Hi @wangwentong-lunaon,

Thank you for report! You're right, it should be fixed.

@ystrot ystrot added this to the 0.9.5 milestone Mar 19, 2019
@ystrot ystrot added the bug label Mar 27, 2019
@ystrot ystrot modified the milestones: 0.9.5, 0.9.6 Apr 4, 2019
mnndnl pushed a commit that referenced this issue May 16, 2019
#548 remove imageContextStack, add scale property to CGContext
231d1ba
@mnndnl mnndnl assigned mnndnl and unassigned ystrot May 16, 2019
@mnndnl
Copy link
Contributor

mnndnl commented May 20, 2019

Hi @wangwentong-lunaon !
This issue fixed in the master branch, thank you for reporting!

@mnndnl mnndnl closed this as completed May 20, 2019
explaineverything pushed a commit to explaineverything/Macaw that referenced this issue May 23, 2019
@lukaszkrystek
Merge branch 'master' into explain/release-1.0.2
7a1cde1 
* master:
  update w3c-test
  update w3c-test
  change location of SVGKeys
  Fix exyte#388: add enum Keys with fill, color and currentColor
  Fix exyte#388: add test for color-prop-05-t-manual
  Fix exyte#388: fix fill for group with currentColor
  Fix exyte#399: add test for struct-use-01-t-manual
  exyte#548 remove imageContextStack, add scale property to CGContext
  exyte#528 fix memory leak with Image objects
  Avoid NPE mentioned in exyte#571: LoadFont with "bold" weight will crash
@ystrot ystrot modified the milestones: 0.9.6, 0.9.7 Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnndnl mnndnl

Labels
bug
Projects
None yet
Milestone
0.9.7
Development

No branches or pull requests
3 participants
@ystrot @mnndnl @wangwentong-lunaon