Project: Refactor build script #49
Conversation
|
Hi, thanks! First of all - please squash the two commits. We don't do it from our side (because of PRs that are more complex) Second of all maybe for @halal-beef - shall we make user builds actually... not print debug logs instead of constantly reversing the commit? Nit not for this PR but as an overall idea Complex review later the day. Thanks for the work! |
|
Wouldn't this break the build testing CI? I'm pretty sure that relies on our build all script |
Sure. |
|
Commit message note btw, please sign off if possible and fix spelling errors, like redundent -> redundant, also please capitalise too. |
|
Commit title note, please follow the linux style commit format, for example here would be Project: Refactor build script |
Yep, CI build failed. |
Luphaestus
changed the title
Luphaestus
force-pushed
the
dev
branch
4 times, most recently
from
53ed95d to
edcdf98
Compare
|
CI passed, will do builds on my personal system and check before approving, great work tho. |
|
nit: please split your commits nit 2: fix your git email :) you don't get authorship |
I guess the first nit is splitting adding configurable printing support and the actual build system refactor? |
it can stay in one PR, we're not the linux kernel, maybe change the pr name but other than that seems fine to me |
remove redundant printf
|
I think I’ve fixed everything? Thank you both for your patience. |
|
whoops didn't mean to do that, github review on mobile isn't the best if @halal-beef can confirm that it's functional and the flag change will be added we can merge it in |
rearranged config output.
right, will do |
|
Invalid parameter for --debug. Use 'y' or 'n'. slight nitpick, -d -debug debug mode. to -d -debug [y/n] debug mode. |
|
oh wait, no sorry but yeah the wording is wrong on that error, should be --verbose |
|
All of the command arguments work, one more nitpick tho in debug.c, please also guard the uart output under the debugging ifdef, otherwise boot may be considerably slower for users |
|
otherwise, amazing work |
|
also one more thing, please do not apply tabs to ifdef |
do this instead |
What is your opinion on #49 (comment) |
Thanks! |
just gave my comment |
|
@BotchedRPR any objections? Will merge in a bit, for now I'm extra tired and will call it a day |
nope, all good |
Rename config output to match new flag names
|
Thank you! |
Removed repeated make commands.
Made help message dynamic and prettier.
Integrated 'lk3rd-build-all.sh'
Added debug flag to more easily show the progress of "all".
Converted User argument to flags.
Allowed the user to run build.sh from any directory.