fix: mark threads as experimental #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdickinson
commented
Jan 8, 2024
| needsClose = false; | ||
| await Promise.all([stdin.close(), stdout.close()]).catch(() => {}); | ||
| }, | ||
| fds: [stdin.fd, stdout.fd, stdout.fd], |
There was a problem hiding this comment.
Deno, unlike Node, runs its "leaked file descriptor" check before the FinalizationRegistry has a chance to fire; so we add the explicit close here.
| let close = async () => { | ||
| closeSync(stdin as any); | ||
| closeSync(stdout as any); | ||
| }; |
There was a problem hiding this comment.
... And Bun returns the wrong type from fs.promises.open, so we guard against that here.
| @@ -77,7 +77,8 @@ export async function createPlugin( | |||
| opts.config ??= {}; | |||
| opts.fetch ??= fetch; | |||
|
|
|||
| opts.runInWorker ??= CAPABILITIES.hasWorkerCapability; | |||
| // TODO(chrisdickinson): reset this to `CAPABILITIES.hasWorkerCapability` once we've fixed https://github.com/extism/js-sdk/issues/46. | |||
| opts.runInWorker ??= false; | |||
There was a problem hiding this comment.
(It's a blink-and-you'll-miss-it diff – this is what actually changes the default threading behavior of the plugin.)
bhelx
approved these changes
Jan 8, 2024
|
It should show up in the ref docs as experimental thanks to the |
Because we're still working out kinks in the implementation [1], users can specifically request that plugins run in the background, but they no longer do so by default where available. Once [1] is fixed, we're likely to make threading default again. [1]: #46
chrisdickinson
force-pushed
the
chris/20240108-unstable-threads
branch
from
d90f062 to
e09566a
Compare
|
(On re-read, it's not clear that we've backed it out waiting on a bugfix; I've updated the ref doc with a link to the bug!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we're still working out kinks in the implementation 1, users can specifically request that plugins run in the background, but they no longer do so by default where available. Once 1 is fixed, we're likely to make threading default again.