New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): install script, ci test install and documentation #84

Merged

bhelx merged 1 commit into extism:main from mtb0x1:main

Jun 8, 2024

Contributor

mtb0x1 commented Jun 6, 2024 •

edited

Loading

The old version attempts to append Path during the install script. The result is flaky and doesn't work reliably :

Doesn't seem to persist value in local settings.
Depending on the console type (cmd or powershell), the result is different
CI vs local whole machine vs User profile ...

This fix removes the auto append and updates install instructions to leave the option to the user.


          fix(windows): install script, ci test install and documentation

bhelx merged commit 067ef55 into extism:main

4 checks passed

Contributor

bhelx commented Jun 8, 2024

Thank you!

bhelx mentioned this pull request

fix: make install dir if not exist #86

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet