Fix error swallowing bug #113
Conversation
Fixes #109 Just a test to repro for now. I tried to upgrade quickjs. Did some other house cleaning while in here. It appears that the problem may be in rquickjs, but maybe we are holding it wrong. Will look with Zach today.
zshipko
force-pushed
the
fix-error-swallowing-bug
branch
from
8914d7b to
0caed1a
Compare
|
I was finally able to fix this 🎊 - it came down to using The commit also includes some fixes for warnings about static mutable values on newer versions of rustc |
|
Sorry i missed that you got this @zshipko ! gonna try it out |
| # ifeq ($(OS),Windows_NT) | ||
| # @python3 -m venv ./.venv && \ | ||
| # ./.venv/Scripts/activate.bat && \ | ||
| # pip install -r examples/host_funcs/requirements.txt && \ | ||
| # python examples/host_funcs/host.py examples/host_funcs.wasm && \ | ||
| # ./.venv/Scripts/deactivate.bat | ||
| # else | ||
| # @python3 -m venv ./.venv && \ | ||
| # . ./.venv/bin/activate && \ | ||
| # pip install -r examples/host_funcs/requirements.txt && \ | ||
| # python3 examples/host_funcs/host.py examples/host_funcs.wasm && \ | ||
| # deactivate | ||
| # endif |
There was a problem hiding this comment.
I'm gonna leave this uncommented and merge.
There was a problem hiding this comment.
@chrisdickinson no rush, but could you chime in as to how to fix this or when another sdk release will happen? i don't recall we had a definitive reason why we were still getting the failure to import here.
There was a problem hiding this comment.
I wasn't able to replicate the extism_sys issue on my machine – I ran into a similar issue with extism-cli but I solved it by upgrading my virtualenv. I think it could be a virtualenv issue – looking back at the error you posted, it doesn't look like you had the target virtualenv active when you uninstalled extism_sys and installed a newer version. The CI looks like it was failing for a different reason, though?
There was a problem hiding this comment.
This must have been some kind of caching issue, the tests are passing now: #116
Fixes #109
Just a test to repro for now. I tried to upgrade quickjs. Did some other house cleaning while in here. It appears that the problem may be in rquickjs, but maybe we are holding it wrong. Will look with Zach today.