Fix Dynamic Tuple Encoding #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch had a bug that new tuple arg types (`%{type: type, name: ...}`) were beign interpreted as "not dynamic" in the `is_dynamic?` code since we had a catch-all that wasn't clear it was incorrectly matching the inner value. We both a) fix the matching, and b) are explicit about declaring this function for all types so we don't silently get it wrong in the future.
Bump to 1.0.0-alpha5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch had a bug that new tuple arg types (
%{type: type, name: ...}) were beign interpreted as "not dynamic" in theis_dynamic?code since we had a catch-all that wasn't clear it was incorrectly matching the inner value. We both a) fix the matching, and b) are explicit about declaring this function for all types so we don't silently get it wrong in the future.Bump to 1.0.0-alpha5