fix!: update crd to apiextensions.k8s.io/v1 #681
Conversation
| type: string | ||
| data: | ||
| type: array | ||
| items: |
There was a problem hiding this comment.
we could set x-kubernetes-preserve-unknown-fields: true to allow extra fields here
| description: Template which will be deep merged without mutating | ||
| any existing fields. into generated secret, can be used to | ||
| set for example annotations or type on the generated secret | ||
| spec: |
There was a problem hiding this comment.
we could set x-kubernetes-preserve-unknown-fields: true to allow extra fields here
|
Hey @Flydiverny im on vacation for the next ~2 Weeks, i'll take a look at when i'm back! |
There was a problem hiding this comment.
Hey @Flydiverny, i'm back from vacation, i'll put my hands on it later today. I found a small issue that prevents e2e tests from running properly.
| type: object | ||
| required: | ||
| - spec |
There was a problem hiding this comment.
The required field is defined twice (that's why the e2e test fails)
There was a problem hiding this comment.
Guess I failed rebase after all 😸 ill see if I get some time to incorporate latest additions as well
|
LGTM! I tested it locally - e2e tests run fine, i can install all provided examples and i double-checked spec/key opts. I think i would not set |
Signed-off-by: Markus Maga <[email protected]>
…: false Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
Signed-off-by: Markus Maga <[email protected]>
|
Finally got around to rebasing this. |
Fixes #680, fixes #645, fixes #621, closes #377
secretDescriptorin CRD validation (its been deprecated forever, wasn't really validated before either but seemed to work regardless)preserveUnknownFields: trueis not allowed)This shouldn't be a breaking change for users as long as the validation schema includes all the possible props. I've gone thru the backends specOptions and keyOptions and I believe I've caught them all.. (assuming no one uses
secretDescriptor)I suppose this also drops support for kubernetes versions <1.16