This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
feat(aws-ssm): Support parameters by path #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmsilveira
changed the title
martina-if
reviewed
Jan 20, 2021
Flydiverny
reviewed
Jan 21, 2021
Flydiverny
changed the title
rjmsilveira
force-pushed
the
feature/support-full-ssm-paths
branch
2 times, most recently
from
d1a17a9 to
7695bca
Compare
Updating Readme Improving code with users suggestions Lint fixes Adding tests for ssm path feature
rjmsilveira
force-pushed
the
feature/support-full-ssm-paths
branch
from
7695bca to
49abbd3
Compare
|
@Flydiverny created one test for this new feature. Let me know if it's enough :) |
|
@rjmsilveira I'm trying to get us off our fork where we use data by path, but seems like I cannot use this approach as I get the following error Why would those be required when the only path is used? |
I forgot to update CRD, all good now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is a replacement of my original approach (#238 )
I have refactored the code to do have as little changes as possible but still supporting the possibility of fetching secrets from a path instead of a key.
Also added support to fetch paths recursively if needed but the default is 0.