Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

chore(vault): require vaultRole, vaultMountPoint, and key #234

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Conversation

silasbw
Copy link
Contributor

@silasbw silasbw commented Nov 25, 2019

No description provided.

@silasbw
Copy link
Contributor Author

silasbw commented Nov 25, 2019

Long term we should consider adopting a per-backend type object. For example:

apiVersion: kubernetes-client.io/v1
kind: ExternalSecret
metadata:
  name: hello-service
spec:
  template:
    metadata:
      annotations:
        external-secret: 'Yes please!'
  vault:
    vaultRole: x
    vaultMountPoint: x
    key: x
  data:
    - key: hello-service/password
      name: password

Existing Kubernetes objects follow this pattern (e.g., volumes). It also makes for a more straightforward validation scheme that produces easy to understand error messages (the error message produced as a result of this PR are a little opaque).

@silasbw silasbw requested a review from Flydiverny November 25, 2019 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants