feat: add validation to CRD #208
Conversation
| @@ -215,6 +215,17 @@ data: | |||
| password: MTIzNA== | |||
| ``` | |||
|
|
|||
| ## Deprecations | |||
| template: | ||
| metadata: | ||
| annotations: | ||
| external-secret: 'Yes please!' |
| name: Age | ||
| type: date | ||
|
|
||
| validation: |
There was a problem hiding this comment.
do you know which version of Kubernetes introduced validation for CRDs? I think we should use validation, but we might need to explicitly call out the minimum version required.
There was a problem hiding this comment.
Seems to be available in 1.12 which is as far back as the official hosted kubernetes docs go now
https://v1-12.docs.kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#validation
think its a fair requirement :)
There was a problem hiding this comment.
Heres the list I was looking for https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/
Seems to have been enabled by default as beta in 1.9+ ( CustomResourceValidation )
CustomResourceSubresources requires 1.11+
No description provided.