fix: remove logging of potentially secret value (#96)

external-secrets · Jun 22, 2019 · 6063f79 · 6063f79
1 parent 66af903
commit 6063f79
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/backends/kv-backend.js b/lib/backends/kv-backend.js
@@ -32,12 +32,14 @@ class KVBackend extends AbstractBackend {
         try {
           parsedValue = JSON.parse(value)
         } catch (err) {
-          this._logger.warn(`Failed to JSON.parse '${value}':`, err)
+          this._logger.warn(`Failed to JSON.parse value for '${secretProperty.key}',` +
+           ` please verify that your secret value is correctly formatted as JSON.` +
+           ` To use plain text secret remove the 'property: ${secretProperty.property}'`)
           return
         }
 
         if (!(secretProperty.property in parsedValue)) {
-          throw new Error(`Could not find property ${secretProperty.property} in secretProperty.key`)
+          throw new Error(`Could not find property ${secretProperty.property} in ${secretProperty.key}`)
         }
 
         return parsedValue[secretProperty.property]