-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Rtools40v2
to test bindings on Windows
#56
Conversation
So Rtools40v2 was pushed to chocolatey and other places, and Windows images here got updated as well. Note that in this scenario, we use the default Rust toolchain for Windows, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
* Enabling CI on dev branch * Disable unmodified jobs * Removed rtools hack * Explicit rtools40v2 * Removing system rtools installation * Handling no base rtools installation * Testing with reset cashe * Reversing back * Removing debug infrastructure * Comments * Switching to new rtools version
This fixes #53.
Rtools40v2 has been recently released.
It includes our hack to please rust compiler and resolves
gcc
linking issue.libR-sys
can now be safely tested using Rtools only (no dependence onmsys2
is required for pre-computed bindings).However, the
setup-r
action currently have a bug that does not allow installing other versions of Rtools40 even if the version string is explicitly specified (see my issue here r-lib/actions#289).There is also a PR to make the new version default (r-lib/actions#287), which will not work until the issue is resolved.
I suggest to leave this PR as a draft for now. As soon as
setup-r
gets updated, we will remove the relevant code (marked with comments in the.yaml
) and will finally have a working setup:https://github.com/Ilia-Kosenkov/libR-sys/blob/a55515f4a999adfa4535aaed57112e3a233864ef/.github/workflows/test.yml#L215-L227