Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Chore) Update node-sass-middleware to v1.0.1 #309

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

(Chore) Update node-sass-middleware to v1.0.1 #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8e437a
(Chore) Update node-sass-middleware to v1.0.1
p4nu May 28, 2022
0c43751
Add backwards compatibility
p4nu May 28, 2022
6abc9db
Use semver instead of custom function
p4nu May 28, 2022
839367c
Downgrade semver version to use `var`s
p4nu May 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion bin/express-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ var path = require('path')
var readline = require('readline')
var sortedObject = require('sorted-object')
var util = require('util')
var semver = require('semver')

var MODE_0666 = parseInt('0666', 8)
var MODE_0755 = parseInt('0755', 8)
Expand Down Expand Up @@ -212,7 +213,15 @@ function createApplication (name, dir, options, done) {
case 'sass':
app.locals.modules.sassMiddleware = 'node-sass-middleware'
app.locals.uses.push("sassMiddleware({\n src: path.join(__dirname, 'public'),\n dest: path.join(__dirname, 'public'),\n indentedSyntax: true, // true = .sass and false = .scss\n sourceMap: true\n})")
pkg.dependencies['node-sass-middleware'] = '0.11.0'
try {
if (semver.satisfies(process.version, '>=10.0.0')) {
pkg.dependencies['node-sass-middleware'] = '1.0.1'
} else {
throw new Error('node-sass-middleware version >=1.0 requires Node.js 10 or higher. Using Node.js 9 or lower.')
}
} catch (e) {
pkg.dependencies['node-sass-middleware'] = '0.11.0'
}
break
case 'stylus':
app.locals.modules.stylus = 'stylus'
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"minimatch": "3.0.4",
"minimist": "1.2.5",
"mkdirp": "0.5.1",
"semver": "5.5.0",
"sorted-object": "2.0.1"
},
"main": "bin/express-cli.js",
Expand Down