-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --es6 option to enable ES6 compliant syntax #200
base: master
Are you sure you want to change the base?
Conversation
const instead of var and template literals instead of concatenation.
Fix to string template handling
to the purpose of the PR.
Is there a chance to land this one? I'll be creating an online course in August and ideally I'd like to use the new feature there. |
@danielkhan it's better to validate your code with eslint(airbnb-es6). there is some issue with app.js and www.js file. |
@alieslamifard are you referring to the result? Right now, the resulting code is not fully airbnb compatible as the non-es6 code wasn't as well. To not fix too much within one PR, this wasn't done deliberately. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
How would one be able to resolve the conflicts? I'm new to this and can't find the conflicts (only that they're in |
Likely only OP or myself can. I will do it when I get around to it, of course. This is just one of the many things on my todo list and I'm not even in my own country right now to do any work anyway. |
@dougwilson - I think it's hard to prevent conflicts when PRs are sitting for such a long time. |
Thank you. Looks like just need to run "npm run lint" to fix the linting errors and it should be good to go, as that is the only thing failing on CI. |
There also seems to be a stray |
P.S. I wanted to add that I am just listing out the things I would look into / modify when landing the PR. You are not required to do anything, as I will do it when landing. Just wanted to state that because I have had people rage close their PR when I was just trying to list the things I would do since they wanted it to land faster. I would prefer that did not happen here and if you feel like not making further changes I will do them no problem. |
@dougwilson - fixed linting problems. Console output is gone. |
When will this PR get merged with master? |
Ok, I am locking this as apparently people are going to keep asking the same question endlessly. |
This PR
const
withvar
if --es6 is setReference Link #167