Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v5 release blog post #1616

Merged
merged 27 commits into from
Oct 15, 2024
Merged

feat: v5 release blog post #1616

merged 27 commits into from
Oct 15, 2024

Conversation

wesleytodd
Copy link
Member

@wesleytodd wesleytodd commented Sep 13, 2024

@wesleytodd wesleytodd requested a review from a team September 13, 2024 15:37
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 146185b
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/670ee51a46f8b900085cff51
😎 Deploy Preview https://deploy-preview-1616--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@blakeembrey blakeembrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of trailed off, let me know if any of this is useful, otherwise I can stop. It feels pretty verbose and speechy today, I think it could be improved by sticking to V5 and future.

_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
@wesleytodd
Copy link
Member Author

wesleytodd commented Sep 13, 2024

Apparently you cannot reply to the review comment directly.

It feels pretty verbose and speechy today, I think it could be improved by sticking to V5 and future.

I did this intentionally. The audience for this specifically is broader than developers. It is a post for leaders and folks outside of our typical audience for a technical changelog. I was going to update the changelog itself to be the "punchier" thing.

I will send this over to Robin and Jen to get their opinion on this before we make too many changes though, because if that is not hitting then I am totally open to taking a different approach.

_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
@juliogarciape
Copy link
Member

@wesleytodd I volunteer to translate your final post into my native language (Spanish) once it is published if you allow me and consider the translation necessary to generate a greater reach.

@crandmck
Copy link
Member

crandmck commented Sep 29, 2024

I'm happy to see this started, even if just in draft version....

I suggest that the initial reviews focus primarily on content and technical accuracy. I'll be happy to work on stuff like voice, tone, wording, grammar, clarity, and so on once the basic content is solidified.

This is just a matter of expediency and follows "levels of edit" best practice. To be clear, this is just my recommendation.

Also, if @wesleytodd is not available to follow through on this for any reason, it could have multiple authors, or even an "Express TC" byline, if that makes sense.

@crandmck crandmck changed the title feat: v5 release feat: v5 release blog post Oct 3, 2024
jonchurch and others added 3 commits October 7, 2024 14:46
specifically, deleted the recommendations to use:

res.send(body, status)
res.json(obj, status)
res.jsonp(obj, status)
@crandmck
Copy link
Member

crandmck commented Oct 9, 2024

I made a full edit pass.

I changed everything to third-person ("we") and changed the byline to "Wes Todd and Express TC" because IMO it's a group effort and also to emphasize that this release was indeed a group effort as well. If Wes really wants to keep just his name on the byline, that's fine, he can certainly change it back.

There are still a three of "TO DO" items, and a mention of the changelog, which apparently is missing (as noted in the blog, lol). If we don't add the changelog before this is published, then we should remove "... for details, see the changelog."

I resolved all the comments above that I addressed or commented accordingly. Hopefully it's clear.

There are still a few unresolved comments that I couldn't address. We should try to do so before publishing if possible.

@crandmck
Copy link
Member

crandmck commented Oct 11, 2024

I made some final polish edits, including adding a links to the sections on each breaking change. LGTM!
IIUC, Wes is out for a while, so once there are enough approvals, do you want to land it @UlisesGascon..?

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon
Copy link
Member

So this is finally ready. @expressjs/express-tc, @expressjs/triagers please review it 🙏.

We plan to land this PR today (12h from now) unless there are request for changes.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳🥳

_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minors changes and typo

_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
_posts/2024-09-12-v5-release.md Outdated Show resolved Hide resolved
@UlisesGascon
Copy link
Member

@sheplu I accepted all the suggestions.

I think that we can release it today @crandmck 👍

@UlisesGascon
Copy link
Member

btw... the date of the blog post is 2024-09-12. should we change it?

@bjohansebas
Copy link
Member

@UlisesGascon yes, the date should be changed, maybe to tomorrow, October 16?

@crandmck
Copy link
Member

I changed it to 10-15, which is today's date (in the US). The only way to do this, currently, is to rename the file.
Ship it!

@crandmck crandmck merged commit 81f0ab3 into gh-pages Oct 15, 2024
5 checks passed
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 3, 2024
* feat: v5 release

* delete duplicated removal notices

specifically, deleted the recommendations to use:

res.send(body, status)
res.json(obj, status)
res.jsonp(obj, status)

* Update _posts/2024-09-12-v5-release.md

Co-authored-by: Blake Embrey <[email protected]>

* Update _posts/2024-09-12-v5-release.md

Co-authored-by: Blake Embrey <[email protected]>

* typos, :name* change per blake

Co-authored-by: Blake Embrey <[email protected]>

* General edits, some review feedback

* Add a missing TO DO

* docs: removed ambiguous reference

* docs: Removed TODO

* docs: linting

* docs: added sponsorship link

* docs: added links to CVE-2024-45590, security triage team and last blog post

* docs: improved metadata

* docs: added explanation in the deprecated APIs

* docs: added section for Migration and Security Guidance

* Final polish, add toc links to breaking change sections

* Change xref to migration guide from changelog

* Update _posts/2024-09-12-v5-release.md

Co-authored-by: Jean Burellier <[email protected]>

* Update _posts/2024-09-12-v5-release.md

Co-authored-by: Jean Burellier <[email protected]>

* Update _posts/2024-09-12-v5-release.md

Co-authored-by: Jean Burellier <[email protected]>

* Update _posts/2024-09-12-v5-release.md

Co-authored-by: Jean Burellier <[email protected]>

* Update _posts/2024-09-12-v5-release.md

Co-authored-by: Jean Burellier <[email protected]>

* Update _posts/2024-09-12-v5-release.md

Co-authored-by: Jean Burellier <[email protected]>

* Update _posts/2024-09-12-v5-release.md

Co-authored-by: Jean Burellier <[email protected]>

* Update _posts/2024-09-12-v5-release.md

Co-authored-by: Jean Burellier <[email protected]>

* Update _posts/2024-09-12-v5-release.md

Co-authored-by: Jean Burellier <[email protected]>

* Move file to change post date

---------

Co-authored-by: Jon Church <[email protected]>
Co-authored-by: Blake Embrey <[email protected]>
Co-authored-by: Rand McKinney <[email protected]>
Co-authored-by: Ulises Gascón <[email protected]>
Co-authored-by: Jean Burellier <[email protected]>
@bjohansebas bjohansebas deleted the v5-blog branch November 9, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.