Correctly invoke async router callback asynchronously #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwilson
suggested changes
Apr 13, 2022
|
@dougwilson Please see the new commit |
|
Great, thank you! Would you be willing to open the same PR over at https://github.com/pillarjs/router ? |
dougwilson
reviewed
Apr 14, 2022
| @@ -203,6 +204,12 @@ proto.handle = function handle(req, res, out) { | |||
| return; | |||
| } | |||
|
|
|||
| // max sync stack | |||
| if (++sync > 100) { | |||
There was a problem hiding this comment.
Without looking at the current v8 stack frames, there is no way to know if you still have 100 frames left to use. Also params will add/remove to how many frames are used in each iteration, I wouldn't think. How did you come up with the number 100 for this?
|
@dougwilson router repo already fixed it: pillarjs/router@e96ebf5 I have a new commit to fix stack overflow with a large sync stack: 538a789 |
|
Ah, I guess we didn't port that over, lol! Thanks for pointing that out. I'll port that commit over to 4.18 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes this error occurs:
RangeError: Maximum call stack size exceeded
This pull request can fix the error.