Use object with null prototype for settings #4835
Conversation
EvanHahn
force-pushed
the
ignore-settings-on-object-prototype-5.x
branch
from
5057a23 to
e49bb35
Compare
|
Just rebased this. |
|
Anything else I should do here? No rush from me, just wanna make sure I'm not blocking anything. |
|
Hey! No, these 5.x changes are good. I'm just waiting to merge after the 4.x branch is merged in to reduce the merge conflicts is all. That should be very soon, as the 4.x changes landed are supposed to be out next week! Thank you for your hard work and discovering this issue. API is more sane now thanks to you 😊 |
|
Great, thanks!! If there are other things that need doing, feel free to reach out to [email protected] and I'll see if I can help. |
|
This has been open for over a year. No rush from me, but let me know if there's anything I can do to move this along. |
EvanHahn
force-pushed
the
ignore-settings-on-object-prototype-5.x
branch
from
e49bb35 to
01395fb
Compare
EvanHahn
force-pushed
the
ignore-settings-on-object-prototype-5.x
branch
from
01395fb to
790d083
Compare
EvanHahn
changed the title
|
It seems that the |
|
#4861 is merged which created a conflict here. If you want to resolve it go for it (its super simple) or I can with a local merge (instead of just clicking the buttons). I will leave it here for a bit and if I don't hear back will merge it when I circle back. |
|
Fixed, I believe. |
|
Hm, it still doesn't like it, but afaict that was the line which changed in both. This is the reason not to leave branches to become stale this long, sorry about the difficulty. I will pull and check it locally now. |
|
🤷 merged in the referenced cherry-picked version above. |
express().settingsis now an object with anullprototype. This simplifies the code.