Resolve paths for views asynchronously #2653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Anyway we can add to this a way to prevent stampeding (which the sync version protected from) to the default lookup implementation? |
|
Oh, yes! I think I could work that in. |
|
Updated. |
aredridel
force-pushed
the
async-view-resolve
branch
from
ef1c5dd
to
1fe4c1e
Compare
aredridel
force-pushed
the
async-view-resolve
branch
from
1fe4c1e
to
e0a65cc
Compare
aredridel
force-pushed
the
async-view-resolve
branch
from
e0a65cc
to
4846365
Compare
This allows extended view classes to implement more interesting lookup methods without changing the interface. Removed useless ext parameter.
aredridel
force-pushed
the
async-view-resolve
branch
from
a048a24
to
4de612f
Compare
This was referenced Jun 2, 2015
Merged
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
5f268a4
to
9848645
Compare
|
👍 |
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
eb10dba
to
340be0f
Compare
46 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the only post-startup synchronous I/O in Express.
In addition, this makes the view.lookup method non-private, intended to be used
by view engines to resolve paths to partials, and, if the View class is
extended, could be used for other resources such as internationalized messages.