Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY up etag and wetag code in ./lib/utils.js #3313

Closed
lpage opened this issue May 18, 2017 · 2 comments
Closed

DRY up etag and wetag code in ./lib/utils.js #3313

lpage opened this issue May 18, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@lpage
Copy link
Contributor

lpage commented May 18, 2017

There is an opportunity to DRY up a bit of code that's in ./lib/utils.js, specifically for exports.etag and exports.wetag. Drying up the code would NOT change the API.

lpage added a commit to lpage/express that referenced this issue May 18, 2017
@dougwilson
Copy link
Contributor

Please, there is no need to file an issue immediately before filing a PR, especially for a non-issue. If there is any conversation, it ends up split between two locations and also creates extra items to track, close, respond to. Thanks!

lpage added a commit to lpage/express that referenced this issue May 18, 2017
@lpage
Copy link
Contributor Author

lpage commented May 18, 2017 via email

lpage added a commit to lpage/express that referenced this issue May 18, 2017
@dougwilson dougwilson self-assigned this Sep 28, 2017
@dougwilson dougwilson added the 4.x label Sep 28, 2017
@dougwilson dougwilson added this to the 4.16 milestone Sep 28, 2017
@dougwilson dougwilson mentioned this issue Sep 28, 2017
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants