Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test up to Nodejs 8 with Travis #36

Merged
merged 2 commits into from
Jul 25, 2017

Conversation

simison
Copy link
Contributor

@simison simison commented Jul 24, 2017

Just adding more Node versions to TarvisCI, but allowing failures with some versions for now.

Let's see how they pass and I'll modify this PR after it.

fast_finish explained here: https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/

Just adding more Node versions to TarvisCI, but allowing failures with some versions for now.
@niftylettuce
Copy link
Contributor

@simison can you drop the failing versions in your PR that throw error in Travis about use of const in strict mode?

@simison
Copy link
Contributor Author

simison commented Jul 24, 2017

@niftylettuce Done!

That breaking change by using "const" should've not gone in before this but oh well. :-)

Hope there aren't too many Node.js v0.12.0'ish users anymore.

@niftylettuce niftylettuce merged commit 3d28d8b into expressjs:master Jul 25, 2017
@simison simison deleted the patch-3 branch July 25, 2017 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants