New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/fix negative or not parsable limit bug #24

Merged

niftylettuce merged 3 commits into expressjs:master from idanto:hotfix/fix-negative-or-not-parsable-limit-bug

Sep 29, 2016

idanto commented Aug 16, 2016

Fix two bugs that related to the limit parameters:

when negative limit is given the calculation of the offset/skip was happening before changing the limit to zero
there was no default for unparsable limit parameters - add zero as default.

In addition I added new tests that will cover all the edge cases of limit and page.

idantovi added 3 commits

August 16, 2016 18:07


          add default for non-parsable limit

85eea5a


          move the offset calculation after the negative limit check


          cover limit and page edge cases with tests

18a57b4

niftylettuce merged commit 5ab3be6 into expressjs:master

Contributor

niftylettuce commented Sep 29, 2016

Published v0.2.2 to NPM. Thanks @idanto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet