Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add ADR template #291

Merged
merged 1 commit into from
Oct 28, 2024
Merged

docs: Add ADR template #291

merged 1 commit into from
Oct 28, 2024

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Oct 22, 2024

closes #285

Note: this template was used in #290 and #289

Signed-off-by: Ulises Gascon <[email protected]>
@UlisesGascon UlisesGascon requested a review from a team October 22, 2024 19:49
@UlisesGascon UlisesGascon self-assigned this Oct 22, 2024
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it could also be added as a PR template.

@carpasse
Copy link

I would stick to the original template

Just because we can easily leverage the ADR generation using one of the available cli tools available on npm

@UlisesGascon
Copy link
Member Author

As agreed on the last TC meeting I am merging the PR. @bjohansebas can you create the PR template?

@UlisesGascon UlisesGascon merged commit 91704b5 into master Oct 28, 2024
@UlisesGascon UlisesGascon changed the title Add ADR template docs: Add ADR template Oct 28, 2024
@UlisesGascon UlisesGascon deleted the adr-template branch October 28, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-thinking the discussion process
5 participants