Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for brotli #194

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Oct 19, 2024

The changes from #172 are brought in, with the exception of using the accept negotiation logic.

@bjohansebas
Copy link
Member Author

It should use accepts, so this PR is not ready yet, and I don't have the option to turn it into a draft. I will soon open a PR in accepts to be able to use this logic

@bjohansebas bjohansebas self-assigned this Oct 19, 2024
@UlisesGascon UlisesGascon requested a review from a team October 20, 2024 17:24
@bjohansebas bjohansebas marked this pull request as draft October 22, 2024 21:07
encoding_negotiator.js Outdated Show resolved Hide resolved
@bjohansebas bjohansebas marked this pull request as ready for review October 24, 2024 00:17
@bjohansebas bjohansebas mentioned this pull request Nov 4, 2024
@bjohansebas
Copy link
Member Author

hi @wesleytodd @blakeembrey, I've updated the options to avoid using object-assign, would love to hear your feedback

index.js Outdated Show resolved Hide resolved
@bjohansebas
Copy link
Member Author

I really don't think there are any more changes to be made here.

@bjohansebas

This comment was marked as outdated.

@bjohansebas bjohansebas marked this pull request as draft December 5, 2024 16:51
@bjohansebas bjohansebas force-pushed the feature/brotli branch 2 times, most recently from ae9da60 to 162f14b Compare December 5, 2024 19:12
@bjohansebas bjohansebas marked this pull request as ready for review December 5, 2024 19:13
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
@Kle0s
Copy link

Kle0s commented Dec 23, 2024

@wesleytodd any chance you have the time to review it once again so it could be merged?

@kapilaggar
Copy link

@bjohansebas @blakeembrey any idea when this PR will be merged and new version will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.