Remove mixinParams function and replace with req.param(...)

[bminer]

The mixinParams function is not necessary because Express 2.0 already provides support for accessing route params, query strings, and HTTP bodies with req.param(...)

See http://expressjs.com/guide.html#req.param() for more information

This should clean up the code a bit. :)

[ctavan]

Hey bminer, thanks for your feedback!

For validation I agree, we should be able to use req.param(). For sanitization however things will become a bit more tricky since we actually want to modify the parameters and req.param() is read-only. So we somehow have to figure out, whether the param we want to sanitize is in req.params, req.query or req.body and write it back to the correct location...

Anyways I agree we should get rid of the mixinParams-method. If you want, you can provide me with a pull-request, otherwise I'll see if I can implement it during the weekend.

[bminer]

Good point. I suppose you could just store back into req.param no matter
what, which is sort of what's happening right now. Or, you could do
something like req.param(...) -- first try replacing req.params[x] if it
exists, otherwise replace req.query[x], then req.body[x]... in that order.
The latter seems like a better approach since you can still access your
vars (sanitized or not) through req.body, req.params, and req.query, but you
can also access them via req.param(...).

I'm not too great with Git, and my time is extremely limited right now. I
could take care of this, but I'd probably just email you the code (I know...
gross). Let me know what you want me to do. If you can get to it this
weekend or whatever, that's fine with me, too. Thanks!

On Thu, Oct 20, 2011 at 8:50 AM, Christoph Tavan <
[email protected]>wrote:

Hey bminer, thanks for your feedback!

For validation I agree, we should be able to use req.param(). For
sanitization however things will become a bit more tricky since we actually
want to modify the parameters and req.param() is read-only. So we somehow
have to figure out, whether the param we want to sanitize is in req.params,
req.query or req.body and write it back to the correct location...

Anyways I agree we should get rid of the mixinParams-method. If you want,
you can provide me with a pull-request, otherwise I'll see if I can
implement it during the weekend.

Reply to this email directly or view it on GitHub:
#1 (comment)

[ctavan]

If you can wait until the end of the weekend, I'll implement your idea.

[bminer]

Thank you very much! Awesome

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.