Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria label for Dot button added #213

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Conversation

paveli
Copy link
Contributor

@paveli paveli commented Nov 26, 2019

What:

Aria label for Dot button added.

Why:

This should be done according to Google Chrome's Lighthouse accessibility test.

How:

Aria-label prop added to dot button.

Checklist:

  • Documentation added/updated (N/A)
  • Typescript definitions updated (N/A)
  • Tests added and passing (N/A)
  • [ x] Ready to be merged

Copy link
Collaborator

@mrbinky3000 mrbinky3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrbinky3000 mrbinky3000 merged commit fdebc3a into express-labs:master Nov 26, 2019
@bcarroll22
Copy link
Contributor

🎉 This PR is included in version 1.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tim-steele
Copy link
Contributor

@allcontributors, please add @paveli for code

@allcontributors
Copy link
Contributor

@tim-steele

I've put up a pull request to add @paveli! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants