Skip to content

Commit

Permalink
Preserve The Specified Timezone In Parse (#633)
Browse files Browse the repository at this point in the history
* Preserve The Specified Timezone In Parse

When parsing a string into a Time using the optional timezone
parameter, set the location of the Time to the timezone's location so
that Format uses that timezone.

* Add More Tests for Preserving Timezone

Add test when timezone is used to parse a date-time.

Add test when timezone is irrelevant because it's a date.
  • Loading branch information
cwarden authored Apr 24, 2024
1 parent ae2a9df commit e6dfb71
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions builtin/builtin.go
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ var Builtins = []*Function{
if err != nil {
return nil, err
}
t = t.In(tz)
return t, nil
}

Expand Down
3 changes: 3 additions & 0 deletions builtin/builtin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ func TestBuiltin(t *testing.T) {
{`duration("1h")`, time.Hour},
{`date("2006-01-02T15:04:05Z")`, time.Date(2006, 1, 2, 15, 4, 5, 0, time.UTC)},
{`date("2006.01.02", "2006.01.02")`, time.Date(2006, 1, 2, 0, 0, 0, 0, time.UTC)},
{`date("2023-04-23T00:30:00.000+0100", "2006-01-02T15:04:05-0700", "America/Chicago").Format("2006-01-02")`, "2023-04-22"},
{`date("2023-04-23T00:30:00", "2006-01-02T15:04:05", "America/Chicago").Format("2006-01-02")`, "2023-04-23"},
{`date("2023-04-23", "2006-01-02", "America/Chicago").Format("2006-01-02")`, "2023-04-23"},
{`first(ArrayOfString)`, "foo"},
{`first(ArrayOfInt)`, 1},
{`first(ArrayOfAny)`, 1},
Expand Down

0 comments on commit e6dfb71

Please sign in to comment.