Skip to content
This repository has been archived by the owner on Sep 25, 2018. It is now read-only.

Commit

Permalink
Unbreaking installation of simulator app
Browse files Browse the repository at this point in the history
@nikki figured this out.

Basically, we had a line looking for the react-native version in the
main xde package.json. Over time, the way we got the path for the simulator
version of the app within the XDE bundle changed, and we didn't use that
data anymore, but the line requesting it was still in the code.

Eventually, the react-native dependency was removed from xde. This caused
the install function to blow up when the version of react-native was requested.

The fix is super simple -- just removing the (now failing) request for the
version data we don't even use.
  • Loading branch information
ccheever committed Mar 27, 2016
1 parent 31c82d7 commit 199aa67
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "xde",
"version": "1.4.0",
"version": "1.5.0",
"description": "The Exponent Development Environment",
"main": "build/main.js",
"scripts": {
Expand Down
2 changes: 0 additions & 2 deletions src/application/simulator.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,7 @@ async function pathToExponentSimulatorAppAsync() {
let versionInfo = await metadata.reactNativeVersionInfoAsync();
let versionPair = [versionInfo.versionDescription, versionInfo.versionSpecific];
let pkgJson = jsonFile(path.resolve(__dirname, '../../template/package.json'));
let version = await pkgJson.getAsync('dependencies.react-native');
return await simulatorAppForReactNativeVersionAsync(versionPair)
// return path.join(await pathToExponentSimulatorAppDirAsync(), 'Exponent.app');
}

async function installExponentOnSimulatorAsync() {
Expand Down

0 comments on commit 199aa67

Please sign in to comment.