Skip to content
This repository has been archived by the owner on Sep 25, 2018. It is now read-only.

Commit

Permalink
Use Chromium's XMLHttpRequest in XDE, Node's http in exp (#1057)
Browse files Browse the repository at this point in the history
* [XDL] Api/ApiV2 now using Axios instead of Request

* yarn

* Ready for PR

* fixes after review

* nit

* Ready for review P3

* removed console log

* Made requested changes + fixed FormData.js

* Remove unused variables

* Stop swallowing errors in Api.downloadAsync

* Download data as an ArrayBuffer

Avoid the extra Blob->ArrayBuffer conversion

* Add missing flow pragma

* Fix asset uploads and publishing from XDE

In order to use XMLHttpRequest and FormData to upload the asset files,
we must read them into a Blob. On Node.js, a read stream can be used
instead.

* Make use of paramsSerializer option of Axios

Simplify the query string handling code.

* Fix axios.request not being called w/o requestOptions

* Revert the removal of fs-mock-setup.js (removed in c5a62a7027d)

* [devtools] Fix API integration test

Apply similar changes as the UserManager changes here:
https://github.com/expo/universe/commit/533b9f7f51897801d198f3540fb95a14b05183d2

fbshipit-source-id: 9565cb1
  • Loading branch information
fson authored and expbot committed Oct 17, 2017
1 parent b1ea4bc commit 0034077
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ui/NewProjectModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ class NewProjectModal extends React.Component {
if (this._currentRequestID === requestID) {
Logger.notifications.info(
{ code: NotificationCode.DOWNLOAD },
Math.round(progress * 100)
progress
);
}
},
Expand Down

0 comments on commit 0034077

Please sign in to comment.