Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios] Drop SDK35 on iOS #8941

Merged
merged 1 commit into from
Jun 24, 2020
Merged

[ios] Drop SDK35 on iOS #8941

merged 1 commit into from
Jun 24, 2020

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Jun 24, 2020

Why

Doing this now to decrease build times and reduce codebase size as we already know SDK35 would be dropped with next release.

How

Ran et rm-sdk

Test Plan

iOS project builds and seems to work as expected.

@tsapeta tsapeta marked this pull request as ready for review June 24, 2020 09:30
@tsapeta tsapeta requested a review from sjchmiela June 24, 2020 09:31
sjchmiela
sjchmiela approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe in expotools and CI. 👍 🧹

@tsapeta tsapeta merged commit d49c144 into master Jun 24, 2020
@tsapeta tsapeta deleted the @tsapeta/ios/drop-35 branch June 24, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjchmiela sjchmiela sjchmiela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsapeta @sjchmiela