Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[file-system][Android] Close connection after successful downloadAsync #5840

Merged
merged 6 commits into from
Oct 15, 2019
Merged

[file-system][Android] Close connection after successful downloadAsync #5840

merged 6 commits into from
Oct 15, 2019

Conversation

bbarthec
Copy link
Contributor

@bbarthec bbarthec commented Oct 2, 2019

Why

Resolves #2976

How

Added response.close()

Test Plan

Create local server with some dummy files:

for i in {0..10000}; do; base64 /dev/urandom | head -c 1000 > "file${i}.txt"; done

launch it

npx http-server

and monitor tcp connections:

netstat -p tcp

run following snack with BASE_URL pointing to created server: snack

@bbarthec bbarthec requested a review from sjchmiela as a code owner October 2, 2019 15:47
sjchmiela
sjchmiela approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@bbarthec bbarthec merged commit 0a8eb53 into master Oct 15, 2019
@bbarthec bbarthec deleted the @bbarthec/filesystem-dowloadasync-android-unclosed-connections branch October 15, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjchmiela sjchmiela sjchmiela approved these changes

Assignees
No one assigned
Labels
FileSystem
Projects
None yet
Milestone
No milestone
2 participants
@bbarthec @sjchmiela