Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-haptics] Move expo-haptics into universal module #3330

Merged
merged 1 commit into from
Feb 6, 2019
Merged

[expo-haptics] Move expo-haptics into universal module #3330

merged 1 commit into from
Feb 6, 2019

Conversation

bbarthec
Copy link
Contributor

@bbarthec bbarthec commented Jan 25, 2019 •
edited
Loading

Why

Resolves #3127

Test plan

ncl haptics screen

To be done:

  • update xdl's modules configuration

@bbarthec bbarthec force-pushed the @bbarthec/haptics-universal-module branch from 8eb53d4 to 8caeb9c Compare January 25, 2019 14:46
@bbarthec bbarthec requested review from sjchmiela and tsapeta January 25, 2019 14:49
tsapeta
tsapeta requested changes Jan 25, 2019
View reviewed changes
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments and suggestions 🙂 Please remember that you need to rebuild JS files after applying suggestions in TS files.

android/expoview/build.gradle Outdated Show resolved Hide resolved
docs/versions/unversioned/sdk/haptic.md Outdated Show resolved Hide resolved
packages/expo-haptics/src/index.ts Outdated Show resolved Hide resolved
packages/expo-haptics/src/index.ts Outdated Show resolved Hide resolved
packages/expo-haptics/src/index.ts Outdated Show resolved Hide resolved
packages/expo-haptics/ios/EXHaptics/EXHapticsModule.h Outdated Show resolved Hide resolved
packages/expo-haptics/android/src/main/java/expo/modules/haptics/HapticsModule.java Outdated Show resolved Hide resolved
packages/expo-haptics/android/src/main/java/expo/modules/haptics/HapticsModule.java Outdated Show resolved Hide resolved
packages/expo-haptics/android/src/main/java/expo/modules/haptics/HapticsModule.java Outdated Show resolved Hide resolved
packages/expo/src/Expo.ts Show resolved Hide resolved
@bbarthec bbarthec force-pushed the @bbarthec/haptics-universal-module branch 2 times, most recently from 32dd528 to 122900e Compare February 5, 2019 14:15
tsapeta
tsapeta requested changes Feb 5, 2019
View reviewed changes
docs/pages/versions/v31.0.0/sdk/haptic.md Outdated Show resolved Hide resolved
ios/Exponent/Supporting/Info.plist Outdated Show resolved Hide resolved
packages/expo/src/Expo.ts Outdated Show resolved Hide resolved
@bbarthec bbarthec force-pushed the @bbarthec/haptics-universal-module branch from 122900e to ac820af Compare February 5, 2019 15:21
@bbarthec bbarthec force-pushed the @bbarthec/haptics-universal-module branch from ac820af to cc14b0b Compare February 5, 2019 15:24
@bbarthec bbarthec merged commit 51bb657 into master Feb 6, 2019
@bbarthec bbarthec deleted the @bbarthec/haptics-universal-module branch February 6, 2019 08:39
@EvanBacon EvanBacon mentioned this pull request Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsapeta tsapeta tsapeta requested changes

@sjchmiela sjchmiela Awaiting requested review from sjchmiela

Assignees
No one assigned
Labels
Haptic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbarthec @tsapeta @jesseruder @EvanBacon