[core] fix self-signed connections in network inspector #32670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: 2f86ce5 Fingerprint diff[
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "fb873df3916bb3a36d68cf9d41e9cbcf6eda5c7a"
}
}
]Generated by PR labeler 🤖 |
expo-bot
added
bot: passed checks
|
Subscribed to pull request
Generated by CodeMention |
lukmccall
approved these changes
Nov 6, 2024
brentvatne
deleted the
@kudo/eng-9914-sdk-49-self-signed-connection-broke-in-sdk-49
branch
Kudo
added a commit
that referenced
this pull request
Nov 14, 2024
# Why fix expo/fetch stuck reported from #21710 (reply in thread) # How it's a regression from #32670. the delegate proxy also being used for expo/fetch. the delegate does not implement the `URLSessionTaskDelegate.urlSession(_:task:didReceive:completionHandler:)` method. so completionHandler does not be called and get stuck. this pr checks whether the delegate method is implemented, otherwise uses the default impelmentatiion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fixes broken self-signed connection from network inspector because we intercepted the URLSessionDelegate. the default delegate disallows self-signed connection.
fixes #24096
close ENG-9914
How
urlSession(_:task:didReceive:completionHandler:)handlerURLProtocolClient, which would be the original URLSessionDelegate handlerurlProtocol(_:didReceive:)is an old interface and not having a completion handler. this pr tries to introduce anURLAuthenticationChallengeForwardSenderto forward the completion handler to URLAuthenticationChallengeSenderTest Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).