[core] Make TS declaration for process an interface
#32464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: b77c7d7 Fingerprint diff[
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "f287922efe03711422468b9f032a92d2d1d360e4"
}
}
]Generated by PR labeler 🤖 |
expo-bot
added
bot: passed checks
tsapeta
force-pushed
the
@tsapeta/core/process-interface
branch
from
0020f2b to
521d0a6
Compare
tsapeta
force-pushed
the
@tsapeta/core/process-interface
branch
from
521d0a6 to
2ec5da5
Compare
|
Subscribed to pull request
Generated by CodeMention |
lukmccall
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently our declaration can conflict/override with other declarations used in the app.
How
Instead of strictly defining
global.processobject, I made a dedicatedExpoProcessinterface.Test Plan
Checks are passing and
process.envis properly typed, i.e. expo-specific variables are available.