feat: remove CRSQLite and support MacOS in expo sqlite

[coolsoftwaretyler]

Why

I love using Expo wherever I can. I've recently been building with React Native for Windows and MacOS and wanted to use the Expo SQLite package.

I did some hacky patching a few weeks ago and wrote about it here. One of the big challenges I ran into was getting CRSQLite to play nice with everything once I updated the Podspec to work for MacOS.

With the upcoming CRSQLite deprecation and removal, I figured I'd bring it up to y'all. I put together a feature request with these details, and figured I'd at least put my patch findings into an actual PR that can be commented on, used, modified, or discarded if this isn't interesting.

How

This PR primarily does two things:

1. Straightforward: lists macos in the platforms of the Podspec for Expo SQLite, which does just about everything a user would need to enable the library in a React Native MacOS project.
2. Probably not mergeable: removes references and the XCFramework bundle for CRSQLite. This is certainly jumping the gun since it's just deprecated, not actually removed. But if SDK 53 is going to remove it, maybe this PR will line up with that.

Alternative to 2: I think to make it work without removing CRSQLite, we just need to add the Mac platform in the XCFramework bundle. I tried to build it from source and generate a new bundle but I couldn't get it to work, and with the upcoming deprecation/removal, I thought maybe a PR like this could just remove the library entirely, haha.

Test Plan

If you follow my blog post, you can step through the decisions I made for all these changes, along with a basic test that runs the basic CRUD operations code from a Mac app. I've seen this work myself, but if you folks want more thorough tests, I'd be happy to contribute with some guidance.

Checklist

• Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
• Conforms with the Documentation Writing Style Guide
• This diff will work correctly for npx expo prebuild & EAS Build (eg: updated a module plugin).

[github-actions]

Subscribed to pull request

File Patterns	Mentions
docs/**	@Simek, @amandeepmittal
packages/expo-sqlite/**	@Kudo, @alanjhughes

Generated by CodeMention

[Kudo]

thanks for having the great pr!
i was hoping to keep cr-sqlite until sdk 53. to support macos, you could just specify the xcframework as ios only. then we don't have to remove cr-sqlite.

also be good to update the expo-module.config.js for ios -> apple
e.g.

{
  "name": "expo-sqlite",
  "platforms": ["apple", "android"],
  "apple": {
    "modules": ["SQLiteModule", "SQLiteModuleNext"]
  },
  "android": {
    "modules": ["expo.modules.sqlite.SQLiteModule", "expo.modules.sqlite.SQLiteModuleNext"]
  }
}

[coolsoftwaretyler]

Thank you, @Kudo! I am at a work event this week but if I get some time to make these changes, I will. If not, I can get to it early next week.

Really appreciate everyone's time on this and I will keep an eye out for any additional change requests.

[coolsoftwaretyler]

Thanks for the review, @Kudo! I think I have implemented the requested changes (including to bring back the crsqlite framework, and updating the changelog). Happy to make additional changes. Have a great day.

[coolsoftwaretyler]

I think I forgot to restore one of the files. I'm able to reproduce the test failure locally for apps/bare-expo/scripts/start-ios-e2e-test.ts so I'll make sure to fix it before my next push.

Error is:

› Compiling BareExpo » SplashScreen.storyboard

❌  (ios/Pods/Target Support Files/Pods-BareExpoMain-BareExpo/ExpoModulesProvider.swift:215:7)

  213 |       SpeechModule.self,
  214 |       SQLiteModule.self,
> 215 |       SQLiteModuleNext.self,
      |       ^ cannot find 'SQLiteModuleNext' in scope
  216 |       StoreReviewModule.self,
  217 |       SymbolModule.self,
  218 |       ExpoSystemUIModule.self,

[coolsoftwaretyler]

apps/bare-expo/scripts/start-ios-e2e-test.ts works locally if I revert the change to packages/expo-sqlite/expo-module.config.json, and the docs in docs/pages/modules/module-config.mdx don't seem to make mention of the apple keyword that was suggested. Is there another format or change I should make here?

[Kudo]

my fault to paste outdated expo-module.config.json. will update your pr and see if the ci getting passed

[Kudo]

fine tune changelog

[Kudo]

here we go 🚀 thanks again for having the great contribution!

[coolsoftwaretyler]

Thank you for all the help! Y'all have a great contribution process here.