Fix/add warning background location expo go #31461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background location services (including geofencing) does not work in Expo Go (it is available in the Simulator on iOS) so we need to emit a warning when users are using background locations in ExpoGo with some explanation about development builds. This commit adds a warning that will be emitted on the console if running Expo Go client. The warning tries to clearify the above issue. Relates to #ENG-12301
After adding Expo Go warning the validate function needed to be renamed.
Co-authored-by: Expo Bot <[email protected]>
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Sep 13, 2024
alanjhughes
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Background location services (including geofencing) has some limitations in Expo Go (it is available in the Simulator on iOS) so we need to emit a warning when users are using background locations in ExpoGo with some explanation about development builds.
How
This commit adds a warning that will be emitted on the console if running Expo Go client. The warning tries to clarify the above issue.
Contributes to #ENG-12301
Test Plan
Tested BareExpo using a patched version of the
isRunningInExpoGofunction.Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).