Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-file-system][next] Add base64(), rename path to uri. #31357

Merged
merged 7 commits into from
Sep 12, 2024

Conversation

aleqsio
Copy link
Contributor

@aleqsio aleqsio commented Sep 6, 2024

Why

Mostly changes to variable names to make them clearer (we now use uri instead of path to better match file:/// URIs).

Also adding base64() function as an alternative to text().

How

Test Plan

Test suite

Checklist

@aleqsio aleqsio changed the title Change path variable to something more descriptive [expo-file-system][next] Add base64(), rename path to uri. Sep 6, 2024
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 6, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Sep 6, 2024

The Pull Request introduced fingerprint changes against the base commit: b3addc3

Fingerprint diff
[
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "../../packages/expo-file-system/android",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "707adbe2a27148d95d72c53e9ddff20a2904432c"
    }
  },
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "../../packages/expo-file-system/ios",
      "reasons": [
        "expoAutolinkingIos"
      ],
      "hash": "fc967fbfde289430f3da90a22e393455e3510ece"
    }
  }
]

Generated by PR labeler 🤖

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 9, 2024
@aleqsio aleqsio requested a review from lukmccall September 9, 2024 11:25
@aleqsio aleqsio force-pushed the @aleqsio/fs-improvements branch from 1200242 to 13c9f46 Compare September 12, 2024 15:49
@aleqsio aleqsio merged commit f346b3b into main Sep 12, 2024
11 checks passed
@aleqsio aleqsio deleted the @aleqsio/fs-improvements branch September 12, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants